open-formulieren / open-forms

Smart and dynamic forms
https://open-forms.readthedocs.io
Other
37 stars 26 forks source link

Ensure submissions tablib.Dataset generation doesn't crash #4752

Closed sergei-maertens closed 1 month ago

sergei-maertens commented 1 month ago

Closes #3629

Changes

Checklist

Check off the items that are completed or not relevant.

sergei-maertens commented 1 month ago

Looks like only the openforms.formio.rendering.tests.test_component_node.FormNodeTests.test_export_always_emits_all_nodes test broke because of this patch, and I'm fairly certain that test is just wrong :)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.56%. Comparing base (97d32bc) to head (02c68e5). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4752 +/- ## ======================================= Coverage 96.56% 96.56% ======================================= Files 746 746 Lines 25191 25202 +11 Branches 3313 3318 +5 ======================================= + Hits 24325 24336 +11 Misses 602 602 Partials 264 264 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sergei-maertens commented 1 month ago

Backports: