open-formulieren / open-forms

Smart and dynamic forms
https://open-forms.readthedocs.io
Other
37 stars 26 forks source link

:sparkles: [#4344] Configurable objects API group in ZGW registration #4758

Closed stevenbal closed 6 days ago

stevenbal commented 1 month ago

previously this was not configurable and always used the ObjectsAPIGroup with the lowest pk to create the client when registering the submission

Closes #4344

Changes

Checklist

Check off the items that are completed or not relevant.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.57%. Comparing base (c50aa99) to head (9abd733). Report is 14 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4758 +/- ## ========================================== + Coverage 96.55% 96.57% +0.01% ========================================== Files 748 748 Lines 25423 25448 +25 Branches 3362 3369 +7 ========================================== + Hits 24548 24576 +28 + Misses 610 608 -2 + Partials 265 264 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stevenbal commented 1 month ago

I tested the import locally, I did notice that there seems to be an issue when exporting/importing a form that has the legacy zaaktype empty, it is not present in the export and causes errors when importing:

image

I think it's unrelated, so I'll create a separate issue for it https://github.com/open-formulieren/open-forms/issues/4779