Closed sergei-maertens closed 1 month ago
So one particularly interesting observation is that in the hottest code path and logic rule evaluation there seems to be much more room for improvement.
With the master
branch, 58% of time was spent in glom
, and there were about 18,5K calls to it. In this patch, 34% of time is spent in glom
, and there are still about 15K calls - so only about 3K calls are stripped away. It could be that many of those led to exception handling and that caused the slowdown, but I can't even begin to imagine what performance is left uncovered if we can bring those 15K to 1K calls, for example.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.57%. Comparing base (
751991d
) to head (d2bd3cf
). Report is 4 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Validated and approved by DH - it's not up to OF 2.6.x levels yet, but a vast improvement over 2.7.x.
Backports:
Closes #4744
Changes
Optimized key access in the
FormioData
data structure.Performance results - the last column are the numbers for this PR. The gains are massive compared to
master
and they improve even on 2.7.x.Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene