open-formulieren / open-forms

Smart and dynamic forms
https://open-forms.readthedocs.io
Other
37 stars 26 forks source link

Feature/open producten price #4790

Closed Floris272 closed 4 days ago

Floris272 commented 4 weeks ago

Closes #...

Changes

Checklist

Check off the items that are completed or not relevant.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 97.19626% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.56%. Comparing base (4486396) to head (709a1d6). Report is 84 commits behind head on master.

Files with missing lines Patch % Lines
src/openforms/contrib/open_producten/tasks.py 58.33% 5 Missing :warning:
...c/openforms/contrib/open_producten/price_import.py 97.05% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4790 +/- ## ======================================== Coverage 96.55% 96.56% ======================================== Files 748 756 +8 Lines 25399 25611 +212 Branches 3354 3387 +33 ======================================== + Hits 24525 24731 +206 - Misses 609 614 +5 - Partials 265 266 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sergei-maertens commented 3 weeks ago

Didn't get to reviewing yet, I'll try to get it done on Monday!

joeribekker commented 4 days ago

Discussed in refinement: We definitely like the general setup of retrieving prices from the product API. Unfortunately, there is now also another product API (Roxit) which differs (ofcourse) and meanwhile we also introduced prices from variables in OF.

So, we really need to take a new approach on this. Closing the Pull Request since we're not merging as is but we will definitely do something similar. You did some valuable work here!