Closed Floris272 closed 4 days ago
Attention: Patch coverage is 97.19626%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 96.56%. Comparing base (
4486396
) to head (709a1d6
). Report is 84 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Didn't get to reviewing yet, I'll try to get it done on Monday!
Discussed in refinement: We definitely like the general setup of retrieving prices from the product API. Unfortunately, there is now also another product API (Roxit) which differs (ofcourse) and meanwhile we also introduced prices from variables in OF.
So, we really need to take a new approach on this. Closing the Pull Request since we're not merging as is but we will definitely do something similar. You did some valuable work here!
Closes #...
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene