Open stevenbal opened 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.60%. Comparing base (
e4fb7bb
) to head (1e6ab24
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
@sergei-maertens I'm trying to fix the issue with the react-select menu being clipped, but I'm not sure how to fix it. I've tried setting a z-index, but that alone doesn't fix the issue. If I try using overflow: visible
, I do see the full menu, but the rest of the modal breaks :/
current situation with overflow
Any ideas on how this can be fixed? Changing the menuPlacement to bottom
will likely cause the same issue in the future, if the list of choices gets long enough
@sergei-maertens I've made the placement bottom and set a maxMenuHeight for the selects used in the modal to avoid overflow issues (https://github.com/open-formulieren/open-forms/pull/4799/commits/efb307d44275fbfdc6ab70e1dd87a68e8e181a18)
Rebased on master - I will now look at the state again and do a thorough review!
I'm not happy yet with the "copy configuration" button and this is a tough nut to crack. After some discussion/debate with Joeri, we've settled on something like this:
When you open the prefill modal, you get the current state (with dropdowns likely empty if this is the initial configuration:
The user clicks the link to copy the settings - this makes the registration dropdown visible:
Clicking the link again just collapse the form row again
Selecting a backend and then clicking the 'copy' button performs the copy as it is right now, but also automatically collapses the form row again at the end to declutter the UI again.
Please also set up the styling properly so that the link and button are nicely aligned.
Closes #4693
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene