Closed sergei-maertens closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.55%. Comparing base (
7bae4ca
) to head (fc2ffd7
). Report is 6 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Yeah lgtm 👍
Closes #4546
Changes
Tested this end-to-end with the SDK PR and noticed some more tweaks were needed.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene