Closed sergei-maertens closed 3 days ago
Attention: Patch coverage is 98.92473%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 96.56%. Comparing base (
c50aa99
) to head (7078014
). Report is 47 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
src/openforms/submissions/views.py | 91.66% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Seems good to me. The only thing I don't get is the "Cosign now" button that is shown when the user completes the form. I saw that the task has this as a requirement but why do we have it there since the cosigning step has to do with another user?
That's for the cases where the cosigner is physically present the original submitter - this makes it possible to finish the full submission more quickly.
Closes #4320 (partly) The frontend aspect is handled in open-formulieren/open-forms-sdk#729
Email/PDF contents will be done in a different PR.
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene