open-formulieren / open-forms

Smart and dynamic forms
https://open-forms.readthedocs.io
Other
37 stars 26 forks source link

Cosign improvements - batch 1 #4808

Closed sergei-maertens closed 3 days ago

sergei-maertens commented 2 weeks ago

Closes #4320 (partly) The frontend aspect is handled in open-formulieren/open-forms-sdk#729

Email/PDF contents will be done in a different PR.

Changes

Checklist

Check off the items that are completed or not relevant.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 98.92473% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.56%. Comparing base (c50aa99) to head (7078014). Report is 47 commits behind head on master.

Files with missing lines Patch % Lines
src/openforms/submissions/views.py 91.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4808 +/- ## ========================================== + Coverage 96.55% 96.56% +0.01% ========================================== Files 748 749 +1 Lines 25423 25499 +76 Branches 3362 3375 +13 ========================================== + Hits 24548 24624 +76 Misses 610 610 Partials 265 265 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

sergei-maertens commented 3 days ago

Seems good to me. The only thing I don't get is the "Cosign now" button that is shown when the user completes the form. I saw that the task has this as a requirement but why do we have it there since the cosigning step has to do with another user?

That's for the cases where the cosigner is physically present the original submitter - this makes it possible to finish the full submission more quickly.