Closed robinmolen closed 3 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.57%. Comparing base (
51f9713
) to head (022d950
). Report is 12 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@robinmolen can you fix the merge conflicts? Also not sure if the failing tests are related to the code changes?
There is a new window.confirm added in a recent commit, in the /form_design/form-creation-form.js
. I'll replace that one now with the new useConfirm
I've replaced the .../form_design/form-creation-form.js
window.confirm
with the useConfirm
. With that, all window.confirm's have been replaced :)
Closes #4798
Changes
Replacing all
window.confirm(...)
confirmations with a new custom React hook (useConfirm
). This new hook is using our Modal component to display the confirmation message. These changes happend to keep the application UI uniform.Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene