open-formulieren / open-forms

Smart and dynamic forms
https://open-forms.readthedocs.io
Other
37 stars 26 forks source link

ZGW UX improvements: select document type #4817

Closed sergei-maertens closed 2 hours ago

sergei-maertens commented 2 weeks ago

Closes #4606 (partially

TODO

Changes

Checklist

Check off the items that are completed or not relevant.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.61%. Comparing base (577b0df) to head (fe771da). Report is 19 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4817 +/- ## ======================================= Coverage 96.60% 96.61% ======================================= Files 749 749 Lines 25563 25616 +53 Branches 3383 3394 +11 ======================================= + Hits 24696 24749 +53 Misses 604 604 Partials 263 263 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

robinmolen commented 4 hours ago

I was wondering, if you still wanted to change the catalogueUrl calculation/usage in the BasicOptionsFieldset.js (you said last week, in my PR of the ZGW products, that you wanted to try something different)

sergei-maertens commented 3 hours ago

I was wondering, if you still wanted to change the catalogueUrl calculation/usage in the BasicOptionsFieldset.js (you said last week, in my PR of the ZGW products, that you wanted to try something different)

Yes, but I'll do that when I get to the medewerker roltype field, since that probably also requires it! So out of scope for this PR, in scope for the next one.