open-formulieren / open-forms

Smart and dynamic forms
https://open-forms.readthedocs.io
Other
37 stars 26 forks source link

Cosign improvements (batch 2) #4838

Open sergei-maertens opened 2 days ago

sergei-maertens commented 2 days ago

Closes #4320 (partially)

Changes

Screenshots

E-mail to submitter before cosigning

image

E-mail to submitter after cosigning

image

PDF generated

image

Checklist

Check off the items that are completed or not relevant.

codecov[bot] commented 22 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.58%. Comparing base (e4fb7bb) to head (774fad2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4838 +/- ## ========================================== - Coverage 96.58% 96.58% -0.01% ========================================== Files 749 750 +1 Lines 25531 25589 +58 Branches 3376 3387 +11 ========================================== + Hits 24659 24715 +56 - Misses 608 610 +2 Partials 264 264 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

sergei-maertens commented 16 hours ago

Putting this one up for review - however keep in mind that I want to do a refactor follow-up PR: