search

open-frames / proxy

A proxy service for safely interacting with Frames and Open Graph data
MIT License
5 stars 2 forks source link

Add a way to pass a meta tag max bytes size to proxy #22

Closed nmalzieu closed 6 months ago

nmalzieu commented 6 months ago

As per our private slack discussion https://converseapp.slack.com/archives/C06D1LM24SH/p1711536899106929

However, since we fetch the frame from the server each time we display it in case it was updated, there is still a big performance impact: this line https://github.com/open-frames/proxy/blob/5a23da9ed05338bf7d7e3d6466869682e712bec1/packages/client/src/actions.ts#L13 parsing a JSON for 800kb just freezes Converse for a few seconds. Add that to the fact that @Fabri ’s bot sends like 5 of them at the same time and the app is just broken Do you think it would be reasonable for the proxy server to remove tags that are too big? Maybe via a parameter that we can toggle when querying it?