search

open-gamma-ray-astro / gamma-astro-data-formats

Data formats for gamma-ray astronomy
https://gamma-astro-data-formats.readthedocs.io
Creative Commons Attribution 4.0 International
29 stars 27 forks source link

Add RA_PNT and DEC_PNT as required header keys in EVENTS #130

Closed cdeil closed 5 years ago

cdeil commented 5 years ago

This PR adds back RA_PNT and DEC_PNT as required header keys in EVENTS .

They were initially in, but then removed already in 2016 in #39 .

There was a lot of discussion on that point there, and I think in the end there was agreement that as long as POINTING isn't used much, those header keys should remain, and it was my oversight that they got lost.

@jknodlseder - OK?

@mackaiver - Please add those header keys for your FACT DL3 FITS writer. I think otherwise your data will not work with ctools, and will stop working with Gammapy soon when we change from accessing that info from the obs index files to accessing it from the EVENTS header.

cdeil commented 5 years ago

I don't think this is controversial, it was just an oversight. Merging this now.

Of course, comments and suggestions still welcome here or in a new issue any time.