search

open-gamma-ray-astro / gamma-astro-data-formats

Data formats for gamma-ray astronomy
https://gamma-astro-data-formats.readthedocs.io
Creative Commons Attribution 4.0 International
30 stars 27 forks source link

Change safe energy header keywords #66

Open cdeil opened 8 years ago

cdeil commented 8 years ago

We are currently using the LO_THRES and HI_THRES keywords for the safe energy thresholds in the ARF and AEFF formats: http://gamma-astro-data-formats.readthedocs.io/en/latest/search.html?q=LO_THRES&check_keywords=yes&area=default

I saw that in this OGIP spec, LO_THRES means something different: http://heasarc.gsfc.nasa.gov/docs/heasarc/caldb/docs/memos/cal_gen_92_002/cal_gen_92_002.html#tth_sEc4 In the RMF it's

LO_THRES - minimum probability threshold used to construct the matrix (matrix elements below this value are considered to zero and are not stored)

Given that it's a cryptic term anyways, I'd suggest we change to something else. E.g. EMINSAFE, EMAXSAFE or really anything else that doesn't conflict with the exiting usage and maybe suggest energy range from the name.

@jknodlseder @cboisson @registerrier @joleroi - Thoughts?

maxnoe commented 6 years ago

What is considered "safe" here?

What's the benefit over EMIN EMAX, is it true or reconstructed?

So maybe EESTMIN or ERECOMIN or ETRUEMIN

jknodlseder commented 6 years ago

I believe that we need in the long run anyway a different scheme, since the "safe" energy thresholds depend on other parameters, such as for example the offaxis angle. I would keep the current keywords until a better scheme is defined.

Le 4 oct. 2016 à 10:07, Christoph Deil notifications@github.com a écrit :

We are currently using the LO_THRES and HI_THRES keywords for the safe energy thresholds in the ARF and AEFF formats: http://gamma-astro-data-formats.readthedocs.io/en/latest/search.html?q=LO_THRES&check_keywords=yes&area=default http://gamma-astro-data-formats.readthedocs.io/en/latest/search.html?q=LO_THRES&check_keywords=yes&area=default I saw that in this OGIP spec, LO_THRES means something different: http://heasarc.gsfc.nasa.gov/docs/heasarc/caldb/docs/memos/cal_gen_92_002/cal_gen_92_002.html#tth_sEc4 http://heasarc.gsfc.nasa.gov/docs/heasarc/caldb/docs/memos/cal_gen_92_002/cal_gen_92_002.html#tth_sEc4 In the RMF it's

LO_THRES - minimum probability threshold used to construct the matrix (matrix elements below this value are considered to zero and are not stored)

Given that it's a cryptic term anyways, I'd suggest we change to something else. E.g. EMINSAFE, EMAXSAFE or really anything else that doesn't conflict with the exiting usage and maybe suggest energy range from the name.

@jknodlseder https://github.com/jknodlseder @cboisson https://github.com/cboisson @registerrier https://github.com/registerrier @joleroi https://github.com/joleroi - Thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/open-gamma-ray-astro/gamma-astro-data-formats/issues/66, or mute the thread https://github.com/notifications/unsubscribe-auth/AC2oV02-T6gXiBDfL2juZkfAqB35uN-bks5qwgk7gaJpZM4KNZky.