open-gitops / documents

📑 Lasting documents from the OpenGitOps project which are versioned and released together (including the GitOps Principles and Glossary)
https://opengitops.dev/
Other
420 stars 47 forks source link

docs(ADOPTION-JOURNEY.md): considerations #43

Closed lloydchang closed 2 years ago

lloydchang commented 2 years ago

Hi @mikecali @OpsM0nkey

Please review https://github.com/open-gitops/documents/pull/43/files

Notable changes are:

  1. In a similar spirit as small 'a' agile, I changed "Small" to lowercase "small" and removed the exclamation mark at the end of "small!"

  2. I realized that we need to include "Consider the right skill set..." — Hence I listed it as number 2

  3. I changed "K8s" to "Container orchestration (e.g. Kubernetes (K8s))" because other container orchestration systems exist if an organization doesn't want to use K8s, but retained K8s as an example

[...]

  1. To make "Enablement strategy" vendor neutral, I changed "Ansible enablement" to "Configuration Management (i.e. Kustomize) enablement"

because Kustomize is in K8s, under the auspices of CNCF. I summarized the subtopic as Configuration Management generically. While Kustomize was introduced by Google in Kubernetes, Ansible is less vendor neutral because Ansible is still owned by Red Hat according to CNCF Landscape

A goal in GitOps Working Group Charter is:

• Project/vendor neutral https://github.com/gitops-working-group/gitops-working-group/blob/main/charter.md

Since I don't have your GitHub email addresses, I listed your GitHub usernames in https://github.com/open-gitops/documents/pull/43/commits/800f24d50b7ffe050f44737db06a850cadee39a9 as placeholders.

Please let me know what your GitHub email addresses are if you want me to change the co-authorship to your GitHub email addresses.

Thank you!

lloydchang commented 2 years ago

@mikecali You mentioned "colleagues" and "we" in https://github.com/open-gitops/documents/issues/19 — To list your colleagues as additional co-authors, please provide their names and GitHub email addresses. Thanks!

mikecali commented 2 years ago

Thanks @lloydchang The doc looks good! I am happy with the outcome As for the colleagues, I would like to tag @SimonDelord @waynedovey

lloydchang commented 2 years ago

@mikecali @SimonDelord @waynedovey @OpsM0nkey What are each of your GitHub user's email address? Thank you!

I ask because:

GitHub uses the email address in the commit header to link the commit to a GitHub user. https://docs.github.com/en/github/committing-changes-to-your-project/troubleshooting-commits/why-are-my-commits-linked-to-the-wrong-user

Otherwise:

If you don't appear in a repository's contributors graph, it may be because: • The email address you used to author the commits isn't connected to your account on GitHub. https://docs.github.com/en/repositories/viewing-activity-and-data-for-your-repository/viewing-a-projects-contributors

OpsM0nkey commented 2 years ago

I meant to reply earlier... nemanja.stefanovic@gmail.com

SimonDelord commented 2 years ago

Hi there, mine's simon.delord@gmail.com cheers, Simon

Le lun. 25 oct. 2021 à 15:22, lloydchang @.***> a écrit :

@mikecali https://github.com/mikecali @SimonDelord https://github.com/SimonDelord @waynedovey https://github.com/waynedovey @OpsM0nkey https://github.com/OpsM0nkey What are each of your GitHub user's email address? Thank you!

I ask because:

GitHub uses the email address in the commit header to link the commit to a GitHub user. https://docs.github.com/en/github/committing-changes-to-your-project/troubleshooting-commits/why-are-my-commits-linked-to-the-wrong-user

https://docs.github.com/en/github/committing-changes-to-your-project/troubleshooting-commits/why-are-my-commits-linked-to-the-wrong-user

Otherwise:

If you don't appear in a repository's contributors graph, it may be because: https://docs.github.com/en/repositories/viewing-activity-and-data-for-your-repository/viewing-a-projects-contributors • The email address you used to author the commits isn't connected to your account on GitHub. https://docs.github.com/en/repositories/viewing-activity-and-data-for-your-repository/viewing-a-projects-contributors

https://docs.github.com/en/repositories/viewing-activity-and-data-for-your-repository/viewing-a-projects-contributors

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/open-gitops/documents/pull/43#issuecomment-950514701, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4LFN2444NGARCJW7AETG3UITLQZANCNFSM5GS4FYXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mikecali commented 2 years ago

@lloydchang - mine is mike.calizo@gmail.com

lloydchang commented 2 years ago

@SimonDelord Your previous reply is redacted (maybe redaction by your email program?)

Hi there,
mine's ***@***.***
cheers,
Simon

Please click https://github.com/open-gitops/documents/pull/43#issuecomment-950555251 to reply with your GitHub email address via GitHub's web version. Thank you.

waynedovey commented 2 years ago

Hi @lloydchang - mine is wdovey@gmail.com. Thanks.

mikecali commented 2 years ago

@lloydchang - you can also add @glimpsovstar as contributor of this. His email is glimpsovstar@gmail.com

lloydchang commented 2 years ago

Thank you @mikecali @OpsM0nkey @SimonDelord @waynedovey @glimpsovstar

As for our next steps, would you kindly try the following? Thanks!

  1. Go to https://github.com/open-gitops/documents/pull/43/files
  2. Click the "Review changes" green button on the right-hand side
  3. Click the "Approve" selection button to "Submit feedback approving these changes."
  4. Click the "Submit review" green button

You can view the rendered ADOPTION-JOURNEY.md file at https://github.com/open-gitops/documents/blob/cb1ddc43c402d200e70e45ae1757d2e6a8468897/ADOPTION-JOURNEY.md

I added your names and email addresses as co-authors in the Git commit at https://github.com/open-gitops/documents/pull/43/commits/cb1ddc43c402d200e70e45ae1757d2e6a8468897

@glimpsovstar — Since I didn't have your full name, and your GitHub name says "djoo" in addition to your GitHub username "glimpsovstar", I listed your co-authorship as:

Co-authored-by: djoo <glimpsovstar@gmail.com>
lloydchang commented 2 years ago

@murillodigital @scottrigby @todaywasawesome Please review, approve, merge when your time permits. Thank you! 🙂

lloydchang commented 2 years ago

@scottrigby @todaywasawesome @murillodigital

Asynchronously, I put this on the agenda for Nov 10, 2021 - WG Fortnightly via Suggesting access because I don't have Editing access at https://docs.google.com/document/d/1hxifmCdOV5_FbKloDJRWZQHq0ge-trXJKF-BgV4wHVk/edit#heading=h.pauqxhcsoepf

Topics:

lloydchang commented 2 years ago

Closed this pull request to revert topic back to the discussion at https://github.com/open-gitops/documents/issues/19#issuecomment-995199132