search

open-gitops / project

Repository for top-level information about the OpenGitOps project
Other
887 stars 36 forks source link

License check failing on CLOMonitor #140

Open RobertKielty opened 1 year ago

RobertKielty commented 1 year ago

There is a license check failure being reported on CLO Monitor in spite of the LICENSE.md file declaring that the Apache 2.0 license is in effect for code.

I think this is because the string "Apache-2.0" is not present in LICENSE.md
I will submit a PR to add the above string to the LICENSE.md file and see if that clears the check. I'll then make a call in conjunction with the CNCF on whether this should be reported as a CLOMonitor bug.

ref : https://clomonitor.io/projects/cncf/open-gitops#project_license

tegioz commented 1 year ago

Hi @RobertKielty 👋

This is Sergio, one of the CLOMonitor's maintainers 🙂

At the moment CLOMonitor tries to detect the license from the content of the LICENSE file. If it's not able to detect it, it tries to use the one that GitHub has detected. The problem is that both options are expecting the full license content to be in that file, but the LICENSE.md file contains instead some links to the license applied on each case. It looks like GitHub isn't identifying it properly either (it should appear on the top right of the repository, instead of View license*).