open-goal / jak-project

Reviving the language that brought us the Jak & Daxter Series
https://opengoal.dev
ISC License
2.82k stars 173 forks source link

[Decompiler] Revisit object file naming #131

Closed water111 closed 3 years ago

water111 commented 3 years ago

The convention for naming object files in the decompiler is challenging for a few reasons.

The current implementation handles this and generates a "map file" that can be used when doing a partial decompilation to keep the naming the same. But the implementation is really confusing and it's hard to convince myself that it's correct.

We can get away with ignoring this issue for a while since all the engine code is located in a single DGO and has no weird duplicates, but I want to clean this up when we starting going through level data.

water111 commented 3 years ago

This was redone since this issue was created. It is still somewhat confusing, but it works.