search

open-goal / jak-project

Reviving the language that brought us the Jak & Daxter Series
https://opengoal.dev
ISC License
2.74k stars 165 forks source link

Credits/Prologue has a distinct black-box on wider aspect ratios #1521

Open skullpanda86 opened 2 years ago

skullpanda86 commented 2 years ago

Describe the Bug

https://youtu.be/JPK14SSUIdg

I updated OpenGoal to v0.1.9, went to run to check some stuff and noticed the prologue was flickering, tried updating my nvidia drivers and it was still doing the same thing.

How To Reproduce

Running it.

Expected Behavior

Too not flicker during the prologue.

Operating System

Windows 11

OpenGOAL Version

Release

Game Version

NTSC 1.0 (black label)

ManDude commented 2 years ago

By flickering do you mean the particles on the dark eco mist were constantly shifting between in front of or behind the mist?

skullpanda86 commented 2 years ago

I guess? like the mist and the particles were basically flickering, you should be able to see in the linked video.

BreakPoints commented 2 years ago

Yeah, the particles are jumping from in front and behind a 4:3 black box that's used for fading the cutscene in and out of black, maybe even darkening the scene. Blending looks borked, the box flickers a bunch.

image

water111 commented 2 years ago

there's not supposed to be a black box there at all, no idea what that's about

water111 commented 2 years ago

any chance that https://github.com/open-goal/jak-project/blob/master/goal_src/levels/village1/sequence-a-village1.gc#L89 requires some change to the sparticle asm stuff that's only in pal?

water111 commented 2 years ago

are you on a > 60 Hz refresh rate monitor?

ManDude commented 2 years ago

any chance that https://github.com/open-goal/jak-project/blob/master/goal_src/levels/village1/sequence-a-village1.gc#L89 requires some change to the sparticle asm stuff that's only in pal?

Only sparticle-launcher (file) is different, and in it only one of the methods was changed. Looks like all the asm code is the same.

BreakPoints commented 2 years ago

are you on a > 60 Hz refresh rate monitor?

I am, yes. Using the NTSC build also so it shouldn't be a PAL issue.

Running on an Nvidia RTX 2080 results in the issue but running on Intel integrated and latest drivers the box is there but doesn't flicker and just darkens the 4:3 area.

skullpanda86 commented 2 years ago

are you on a > 60 Hz refresh rate monitor?

So I did a little further testing today and yeah I think the issue is tied to the users monitor refresh rate, because as soon I tried enabling vsync and it stopped, the only problem is as soon you reopen the game you have to manually reenable vsync.

BreakPoints commented 2 years ago

That makes sense as my Intel device that didn't have the issue was already limited to 60Hz

BreakPoints commented 2 years ago

Flickering is fixed at 150FPS as of 0.1.12 but the black box remains. I think it just has to be scaled for wider aspect ratios image

ManDude commented 2 years ago

Yeah, that would do it. I'm leaving all of the stupid garbage sprite scaling and positioning for last because it's annoying to deal with.