open-goal / jak-project

Reviving the language that brought us the Jak & Daxter Series
https://opengoal.dev
ISC License
2.74k stars 165 forks source link

g/j2: workaround intermittent lifeseed DMA crash #3418

Closed xTVaser closed 3 months ago

xTVaser commented 3 months ago

This is not a fix, but it temporarily works around the potential crash discussed here https://github.com/open-goal/jak-project/issues/2988

As long as this doesn't impact other things, this feels like a good interim fix, as having a broken cutscene is better than a fatal crash and it might be some time before this is properly identified and fixed.

xTVaser commented 3 months ago

macOS tests seems to often intermittently crash over exit code 132 now after updating from 11 to 12?

Seemingly no logs to shed light on the problem, but i did see this (which also happens on successful runs...):

Warning: /Users/runner/work/jak-project/jak-project/third-party/googletest/googletest/src/gtest-death-test.cc:1124:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 5 threads. See https://github.com/google/googletest/blob/master/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out.