open-goal / open-goal.github.io

OpenGOAL Project Landing Page
ISC License
31 stars 15 forks source link

The "Getting started" button seems to not function #233

Closed yodaxtah closed 3 months ago

yodaxtah commented 3 months ago

I noticed the "Getting started" button doesn't do anything, or so it seems.

image

I expect it to take me to the installation documentation page perhaps, but when clicking it now, nothing seems to process the click. I suppose it's not intended. I checked both on Firefox and Ungoogled-chromium.

Nice work on the website btw. Haven't encountered any c is not a function since the renewal.

yodaxtah commented 3 months ago

Okay, so the button is in src/components/LauncherDownloadLink/index.js. I had a further look.

<Button
  sx={{
    fontFamily: "Roboto Mono",
    /*...*/
  }}
>
  Getting Started
</Button>

Is it possible an onClick was intended here? The button on the left of the image is a SplitButton that passes the url property to LoadingButton's onClick, which looks like this:

<LoadingButton
  loading={isLoading}
  onClick={(event) => {
    window.location.href = primaryButtonUrl;
  }}
  sx={{ /*...*/ }}
>
  ...
</LoadingButton>

Based on that, the non-functional button perhaps should look like this?

<Button
  onClick={(event) => {
    window.location.href = "proper url to a page such as https://opengoal.dev/docs/usage/installation/";
  }}
  sx={{
    fontFamily: "Roboto Mono",
    /*...*/
  }}
>
  Getting Started
</Button>
xTVaser commented 3 months ago

yup you're right, just missed it