open-goal / opengoal-vscode

VSCode Extension for OpenGOAL
ISC License
17 stars 2 forks source link

nrepl: allow customizing nrepl port #334

Closed xTVaser closed 8 months ago

xTVaser commented 8 months ago

I'm not going to try to automatically detect and assume the port because the port can be customized via flags or the repl-config. Basically, it needs to be customizable for that reason, and if it is then the problem is solved.

Additionally because in the long-term, the automatic port assignment based on the game version should be removed from goalc as it's a niche user-specific concern -- if someone wants the different games to use different ports they can use the per-game repl configuration. However what these users probably actually want is a way to disable the nrepl -- something else that can be added to the configuration easily.

Fixes #320