open-hand / choerodon-starters

This is the toolkit developed by Choerodon and provides some basic dependencies for use in the development process.
http://choerodon.io
Apache License 2.0
78 stars 64 forks source link

starter-config-client 路由定位器解析路由BUG #11

Closed bojiangzhou closed 5 years ago

bojiangzhou commented 5 years ago

image image image BeanUtils.copyProperties 方法在反射赋值时,调用ZuulRoute.setSensitiveHeaders方法时,始终都会将customSensitiveHeaders设置为true,导致全局设置的过滤敏感头信息不生效。 建议先判断sensitiveHeaders列表非空再调这个方法。

ghost commented 5 years ago

你说得对,此版本会修复这个问题,beanCopy将修改为:

private static ZuulProperties.ZuulRoute beanCopy(ZuulRoute route) {
    ZuulProperties.ZuulRoute zuulRoute = new ZuulProperties.ZuulRoute();
    org.springframework.beans.BeanUtils.copyProperties(route, zuulRoute, "sensitiveHeaders");
    if (route.getSensitiveHeaders() != null && !route.getSensitiveHeaders().isEmpty()) {
        zuulRoute.setSensitiveHeaders(route.getSensitiveHeaders());
    }
    return zuulRoute;
}