search

open-hand / devops-service

DevOps Service is the core service of Choerodon. It integrated several open source tools to automate the DevOps process of planning, coding, building, testing, and deployment, operation, monitoring.
http://choerodon.io
61 stars 77 forks source link

missing filter on object type while retrieve the instance value? #2

Closed mumutu66 closed 5 years ago

mumutu66 commented 5 years ago

https://github.com/choerodon/devops-service/blob/c3b16350002891254a52eba00e204260337bea52/src/main/resources/mapper/ApplicationInstanceMapper.xml#L177

since here maybe exist multi object type's like service ingress , why no filter on the object type i.g object = "instance" . on the condition if the object id is equla to some instance id while the type is not instance may lead some unexpected behavior?

zhuzhiyang commented 5 years ago

Because the role of this sql is to query the values of the instance deployment, create service and inress is not associated with values

zhuzhiyang commented 5 years ago

You are right, this sql will cause a bug, we will fix it in the next version, thank you for your suggestion!