search

open-horizon / .github

Open Horizon Profile
3 stars 5 forks source link

appendix added #3

Closed rgrupesh closed 2 years ago

rgrupesh commented 2 years ago

It adds appendix and glossary of terms in the readme.md.

Fixes #4

rgrupesh commented 2 years ago

@joewxboy What else do I need to add? Seems like I did not signed the commit message.

joewxboy commented 2 years ago

@rgrupesh two pieces of feedback:

  1. All PRs should be based on an issue. Can you please open an issue for this (feature request) and link it to the PR?
  2. Your commit is missing a sign-off. See if you can amend the previous commit to add the sign-off. For more info, see the "attest" section: https://open-horizon.github.io/common-requests/contribute.html
rgrupesh commented 2 years ago

@rgrupesh two pieces of feedback:

  1. All PRs should be based on an issue. Can you please open an issue for this (feature request) and link it to the PR?
  2. Your commit is missing a sign-off. See if you can amend the previous commit to add the sign-off. For more info, see the "attest" section: https://open-horizon.github.io/common-requests/contribute.html

Signed-off added, yet checks have failed. Why is that?

rgrupesh commented 2 years ago

@rgrupesh two pieces of feedback:

  1. All PRs should be based on an issue. Can you please open an issue for this (feature request) and link it to the PR?
  2. Your commit is missing a sign-off. See if you can amend the previous commit to add the sign-off. For more info, see the "attest" section: https://open-horizon.github.io/common-requests/contribute.html

Signed-off added, yet checks have failed. Why is that?

I see. It requires all commit messages to contain signed off line.