blakep7 commented 5 months ago

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3997

Type of change

Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Tested in fork to ensure that workflow runs, completes, and generates the necessary MacOS arm64 package.

Additional Context (Please include any Screenshots/gifs if relevant)

This uses the exact same process as the amd64 mac build, but on the new M1 runner.
New M1 runner is free for open source ...

Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings
[x] I have tagged the reviewers in a comment below incase my pull request is ready for a review
[x] I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

bencourliss commented 5 months ago

@blakep7 do we need to update this line when installing Docker? https://github.com/open-horizon/anax/blob/f5fa1a60efdba01d965d9cd54582316682dd70d4/.github/workflows/build-push.yml#L477?

blakep7 commented 5 months ago

@blakep7 do we need to update this line when installing Docker?

https://github.com/open-horizon/anax/blob/f5fa1a60efdba01d965d9cd54582316682dd70d4/.github/workflows/build-push.yml#L477

?

No need I believe. The Mac Push job runs on an ubuntu runner for both architectures and steals the already created packages from the Mac Build job.