Before, secrets were considered and UNSTRUCTURED type, and created last. This is problematic for Deployment resources that may depend on an ImagePullSecret being created first.
Fixes #4081
Type of change
Please delete options that are not relevant.
[X] Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Tested by installing a service to a k3d cluster running on Ubuntu 20.04 that includes a Deployment YAML and a ImagePullSecret YAML.
Before the install would fail multiple times due to image pull errors before eventually succeeding.
Now, the install succeeds on the first try. No image pull errors present anymore.
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist:
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings
[ ] I have tagged the reviewers in a comment below incase my pull request is ready for a review
[ ] I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.
Description
Before, secrets were considered and UNSTRUCTURED type, and created last. This is problematic for Deployment resources that may depend on an ImagePullSecret being created first.
Fixes #4081
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested by installing a service to a k3d cluster running on Ubuntu 20.04 that includes a Deployment YAML and a ImagePullSecret YAML.
Before the install would fail multiple times due to image pull errors before eventually succeeding.
Now, the install succeeds on the first try. No image pull errors present anymore.
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: