search

open-horizon / devops

Devops processes to build and deploy horizon components
Apache License 2.0
10 stars 43 forks source link

sdo: fix tests and remove outstanding sdo refs #166

Closed jvidalallende closed 4 months ago

jvidalallende commented 5 months ago

Tests included in test-mgmt-hub.sh were still looking for sdo-related container and configuration URL, and that made the test fail.

Also, remove from deploy-mgmt-hub.sh any outstanding reference to SDO, since it is no longer part of the OpenHorizon deployment.

Fixes: #165

jvidalallende commented 5 months ago

Just noticed that there is already an open PR (#163) that addresses same problem, although in this PR I also remove a few other outstanding references to SDO so I think this is more complete. Anyway feel free to close this one if you prefer to merge the one that was submitted earlier.

I missed #163, as I only looked for issues open regarding the failing tests, and saw nothing (this is why I also opened #165 to track it).

naphelps commented 4 months ago

@jvidalallende Thanks for your contribution. The extra SDO references you are removing in this PR we actually want to stay. These remove any SDO instances from older deployments.

jvidalallende commented 4 months ago

Thanks @naphelps , then I'm closing both the issue I opened and this PR, as both are not needed now that #163 is merged.