open-horizon / edge-sync-service

Cloud - Edge synchronization service (MMS)
Apache License 2.0
24 stars 26 forks source link

SPBD Issue: Errors unhandled. writer.Write() Severity: Low #75

Open peeksake opened 3 years ago

peeksake commented 3 years ago

Static scan results of ESS on 7/22 reveal the following errors, and per @dabooz each of these should be evaluated.

/tmp/edge/repos/codescans/edge-sync-service/core/communications/httpCommunication.go (line 805)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/communications/httpCommunication.go (line 430)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/communications/httpCommunication.go (line 362)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/communications/httpCommunication.go (line 165)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/communications/communicator.go (line 141)
Errors unhandled.
    buffer.WriteString("\n")
    writer.Write(buffer.Bytes())
}

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 3987)
Errors unhandled.
    buffer := bytes.NewBufferString(errorMessage)
    writer.Write(buffer.Bytes())
    return false

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 3955)
Errors unhandled.
    buffer.WriteString("\n")
    writer.Write(buffer.Bytes())
    return false

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 3925)
Errors unhandled.
    buffer.WriteString("\n")
    writer.Write(buffer.Bytes())
    return false

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 3841)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 3119)
Errors unhandled.
        writer.WriteHeader(http.StatusForbidden)
        writer.Write(unauthorizedBytes)
        return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 3101)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 2988)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 2924)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 2862)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 2728)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 2722)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 2530)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 2345)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 2174)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 2048)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 1778)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 1686)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 1607)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 1232)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 1221)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 1042)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 1034)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 890)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 760)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 742)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 650)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
}

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 628)
Errors unhandled.
        writer.WriteHeader(http.StatusForbidden)
        writer.Write(unauthorizedBytes)
    }

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 617)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 342)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 317)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 147)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return

/tmp/edge/repos/codescans/edge-sync-service/core/base/apiServer.go (line 109)
Errors unhandled.
    writer.WriteHeader(http.StatusForbidden)
    writer.Write(unauthorizedBytes)
    return
mikehyde commented 2 years ago

CPR: https://github.ibm.com/ccs-ciso/CISO-Issue-Management/issues/3724