search

open-horizon / examples

Code examples you can use with Horizon.
Apache License 2.0
40 stars 65 forks source link

Make single-arch patterns for helloMMS in exchangePublishScript.sh #288

Closed bmpotter closed 4 years ago

bmpotter commented 4 years ago

In the helloMMS PR i modified object.json to have the destinationType field set to the single-arch pattern, so that in the CreateService.md we didn't have to make them build their docker image for all 3 arch's. But this also means that for the "Use" case (README.md), in order to use the same object.json they need to have the single-arch patterns available to them in the IBM org.

I added a helloMMS make target called publish-only-pattern-each-arch to create these single-arch patterns, so exchangePublishScript.sh needs a special-case to run that (in addition to make publish-only) for the helloMMS dir.

t-fine commented 4 years ago

Going to solve this by expanding the helloMMS makefile publish-only target to the following:

publish-only:
    ARCH=amd64 $(MAKE) publish-service-overwrite
    ARCH=arm $(MAKE) publish-service-overwrite
    ARCH=arm64 $(MAKE) publish-service-overwrite
    hzn exchange pattern publish -f horizon/pattern-all-arches.json
    $(MAKE) publish-only-pattern-each-arch
bmpotter commented 4 years ago

I added that to PR https://github.com/open-horizon/examples/pull/287 so closing this issue