search

open-horizon / examples

Code examples you can use with Horizon.
Apache License 2.0
40 stars 64 forks source link

Per PR 331, templatize config files, use env var & makefile to generate #382

Open joewxboy opened 4 years ago

joewxboy commented 4 years ago

Is there an issue open for this TODO?

Originally posted by @dabooz in https://github.com/open-horizon/examples/pull/331

There is now!

In each of the three services (volantmq, fft_server, fft_client) there are configuration files in the horizon folder that require manual editing per the INSTALL.md instructions.

Please create templates for those files so that they do not need to be modified by hand. Then use the Makefiles to perform an envsubst on the templates to auto-generate the files. This will require the creation and use of a few new environment variables, but some already exist that can be used here.

Once this change is made, please update the INSTALL.md documentation accordingly to remove the sections about manually editing the config files, and instead add a section about pre-populating the environment variables.

dcmartin commented 4 years ago

Example standard (de facto) variables : https://github.com/dcmartin/open-horizon/blob/master/docs/MAKEVARS.md

rajpratyush commented 3 years ago

@joewxboy I would like to take this issue

joewxboy commented 3 years ago

@rajpratyush Let me know if you have any questions.

rajpratyush commented 3 years ago

@joewxboy Cannot find these volantmq, fft_server, fft_client folders in the services is it on a different branch?

joewxboy commented 3 years ago

@rajpratyush It looks like the PR has not yet been merged. I'll see if David Booz and Troy Fine will approve merging it.

rajpratyush commented 3 years ago

@joewxboy ok sir