search

open-horizon / examples

Code examples you can use with Horizon.
Apache License 2.0
40 stars 65 forks source link

Issue #572 - Move SDR documentation to SDR repo #573

Closed johnwalicki closed 1 year ago

johnwalicki commented 1 year ago

Signed-off-by: John Walicki johnwalicki@gmail.com

This PR fixes #572

Add the SDR doc and diagram to the example SDR directory as first step of sunsetting the SDR docs from the Open Horizon Documentation website.

t-fine commented 1 year ago

@johnwalicki hm, do you think these files would fit better in the edge/evtstreams/sdr2evtstreams directory? That is more of the "top level application" of the SDR service. Or maybe a few key files could just be duplicated?

johnwalicki commented 1 year ago

@t-fine Possibly, I don't have an opinion. I've never implemented this service. My goal was to preserve the documentation / image files and kill off the OH SDR docs.

Where do you recommend?

t-fine commented 1 year ago

@johnwalicki alright yeah then if you don't mind moving them over to edge/evtstreams/sdr2evtstreams that would be awesome

johnwalicki commented 1 year ago

@t-fine I've pushed another commit into this PR which moves the SDR architecture diagrams to the edge/evtstreams/sdrevtstreams directory.

Please review / approve if appropriate.

t-fine commented 1 year ago

@johnwalicki this looks good to me! I'll go ahead and merge. Sorry for the delay