Open johnwalicki opened 2 years ago
Look at proper name and trademark examples on this page: https://open-horizon.github.io/docs/installing/adding_devices.html
Podman
and Netavark
should be substitution strings
Hello @johnwalicki, Can I be assigned this issue ? I was able to reproduce it on my system locally and got an idea of what needs to be done.
I think there are two parts to this issue :
podman
and Netavark
)@saurav1004 You got it. "@" mention us if you have any questions.
Ubuntu ?
Ubuntu ?
Yup I am on Ubuntu
@joewxboy @johnwalicki I have added some missing markers in the adding_devices.md
file. Also, I updated the keywords.yml
to include a few additional proper names. Should I submit a PR, so you can review the changes and confirm ?
Once confirmed I can make similar changes in all the remaining files of the repo.
Ubuntu ? Yup I am on Ubuntu
That's good, but I meant that Ubuntu could be a substitution string.
Instead of a PR and pile of commits and reviews. Let's discuss the list of possible new keywords here first. Once we settle on a list, then work on a PR. That might save you a ton of frustrating rework.
Ahh I should have understood.😄 Yeah sure we can do that.
These are the ones I have found till now from looking at the docs/installing/adding_devices.md
file. There could be more in other files too.
Good list. I would remove acronyms from the list; SSH, SSD, WiFi and WPA2
Let's ask @Rene-Ch1 to comment. She's our editor and tech writer expert.
Sure. I will keep adding new suggestions in the same comment as updates below the ones I have listed already.
Do we need to add armhf or arm64
Do we need to add armhf or arm64
arm64 I suppose. But what I am confused about is, there are mentions of just ARM as well, they too need to be marked separately right ?
@saurav1004 Are you still working on this, or can I assign it to someone else?
Is your feature request related to a problem? Please describe.
If / when the documentation is translated, we don't want proper names, trademarks to be translated. Words like Intel, Fedora, MacOS, IBM Cloud,
The Open Horizon Documentation repo adds these words to a keyword file at https://github.com/open-horizon/open-horizon.github.io/blob/master/_data/keyword.yml
In the Markdown .md files, the keywords are marked eg
{{site.data.keyword.fedora}}
We should search through the markdown files. For instance:
I'll continue this idea.
Describe the solution you'd like.
No response
Describe alternatives you've considered
No response
Additional context.
No response