dotarjun commented 9 months ago

Pull Request Template

Fixes # 523

Type of change

Please delete options that are not relevant.

guration

...

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings
[x] I have tagged the reviewers in a comment below incase my pull request is ready for a review
[x] I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

dotarjun commented 9 months ago

@joewxboy

johnwalicki commented 9 months ago

This commit fixes #523 Not #525

johnwalicki commented 9 months ago

I recommend a rewrite of the commit message so that it follows the Open Horizon convention.

dotarjun commented 9 months ago

This commit fixes #523 Not #525

my bad. I have fixed the commit message

johnwalicki commented 9 months ago

Better! Thanks. Can you rewrite the git commit message to be Issue #523 - style: fix navbar text color