open-hpi / openhpi

Other
6 stars 10 forks source link

CRIT messages could be handled better #1950

Closed mohandev2 closed 6 years ago

mohandev2 commented 7 years ago

There are many error messages that do not have enough context. It looks like there may be memory leaks during errors (like the function returns and some of the memory allocated are not released). The following are some examples where bay number, uid_status, the actual response in invalid_response etc etc could have been obtained and given in the message. May 8 14:51:06 openhpi-rhel72 openhpid: ov_rest: ov_rest_control.c:540: Invalid uid status May 8 14:51:06 openhpi-rhel72 openhpid: ov_rest: ov_rest_control.c:218: Failed to get the uid status May 8 14:51:06 openhpi-rhel72 openhpid: ov_rest: ov_rest_power.c:321: Invalid Response May 8 14:51:06 openhpi-rhel72 openhpid: ov_rest: ov_rest_control.c:672: Failed to get the power state RDR May 8 14:51:06 openhpi-rhel72 openhpid: ov_rest: ov_rest_control.c:209: Failed to get the power state RDR

Reported by: mohandev2

Original Ticket: openhpi/bugs/1950

mohandev2 commented 7 years ago

Original comment by: mohandev2

mohandev2 commented 7 years ago

Original comment by: ShyamalaH

mohandev2 commented 7 years ago

Fixed in revision 7715.

Original comment by: ShyamalaH