search

open-hpi / openhpi

Other
7 stars 10 forks source link

2721 top level readme #2727

Closed HemanthBeecherla closed 6 years ago

HemanthBeecherla commented 6 years ago

Please take a final look at this changes.

Thanks, Hemanth

mohandev2 commented 6 years ago

Hi Hemantha,

The patch look far better this time. I still suggest couple of changes.

  1. The Home.md could be Readme.md which may automatically render.
  2. This could be on a new branch without much history.
  3. I do not know what to do with three files which are completely out of date. They are Status.md and the two image files. a. We could avoid them, b. We could have them in the first pull request and have a second pull request to remove them c. We could modify and create the pull request which will be lot of work. What do you think?

Regards Mohan

From: HemanthBeecherla notifications@github.com Sent: Thursday, August 23, 2018 3:53:01 PM To: open-hpi/openhpi Cc: Subscribed Subject: [open-hpi/openhpi] 2721 top level readme (#2727)

Please take a final look at this changes.

Thanks, Hemanth

You can view, comment on, or merge this pull request online at:

https://github.com/open-hpi/openhpi/pull/2727

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/open-hpi/openhpi/pull/2727, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AR0lmD0zt2aWTHMAscdkVeN6kEixXsLJks5uTyQ9gaJpZM4WKaYN.

HemanthBeecherla commented 6 years ago

Hi Mohan,

I think first we check in all the files and we request send pull request to remove those 3 files.

Thanks, Hemantha Reddy

mohandev2 commented 6 years ago

Another pull request was merged. So closing this one. This branch could be deleted.