open-i18n / rust-unic

UNIC: Unicode and Internationalization Crates for Rust
https://crates.io/crates/unic
Other
234 stars 24 forks source link

Implement Unicode Name - NR1 #208

Closed eyeplum closed 6 years ago

eyeplum commented 6 years ago

This pull request includes the implementation for Unicode Name - NR1 (#171).

CAD97 commented 6 years ago

Looks decent, I'll do a proper review over the weekend when I've got a bit of time.

This regex grabs the information that you need:

(?xm)^ # every line
([[:xdigit:]]{4,6}) # codepoint
;[[:blank:]]*
([[:alpha:]]*) # jamos

And you're going to want to write it out as a DirectCharTable

bors[bot] commented 6 years ago

:v: eyeplum can now approve this pull request

eyeplum commented 6 years ago

bors: r+

bors[bot] commented 6 years ago

Build succeeded