open-i18n / rust-unic

UNIC: Unicode and Internationalization Crates for Rust
https://crates.io/crates/unic
Other
234 stars 24 forks source link

Test Unicode 11.0 Beta files #219

Closed behnam closed 5 years ago

behnam commented 6 years ago

We want to test new Unicode 11.0 data to make sure:

Source data files:

See Also:

CAD97 commented 6 years ago

Assuming everything goes perfectly, it should be as simple as changing one line...

https://github.com/behnam/rust-unic/blob/a2d51096c5e3f8faf727f87e716ed6db5daf04bc/data/sources.toml#L1-L3

and then rerunning the download script cargo run --package=unic-data.

behnam commented 6 years ago

Automated way wouldn't work that well, because the beta directories, although named similar to the normal release (:facepalm:), do not include all the files, but only those changed so far. So... needs manual work.

As a side note, @CAD97, the hyper client doesn't check HTTP Response status code and saves 404 HTML content into destinations. Would be good to just report and skip the file in those cases. What do you think? Filing another task for it?

CAD97 commented 6 years ago

Maybe I should have checked the directory before assuming 🙃 but it should be possible without touching the code just by modifying sources.toml to refer to and rename the files in question.

I filed #220 for handling bad responses.

Alexendoo commented 6 years ago

Since unicode 11 was released, the directories now contain the final data

behnam commented 5 years ago

Tracking Unicode 11.0-related updates in #259. No need to keep this open anymore.