search

open-i18n / rust-unic

UNIC: Unicode and Internationalization Crates for Rust
https://crates.io/crates/unic
Other
234 stars 24 forks source link

Data download should ignore+log 404 responses #220

Closed CAD97 closed 5 years ago

CAD97 commented 6 years ago

https://github.com/behnam/rust-unic/blob/a2d51096c5e3f8faf727f87e716ed6db5daf04bc/data/src/client.rs#L41-L48

Rather than just take the response body and add it to the file, check response code first, and log anything that isn't 200 OK

behnam commented 5 years ago

We don't download data in UNIC anymore. :)