Fix path warnings in `use` declarations for beta and nightly

open-i18n / rust-unic

UNIC: Unicode and Internationalization Crates for Rust

https://crates.io/crates/unic

Other

234 stars 24 forks source link

Fix path warnings in `use` declarations for beta and nightly #233

Closed eyeplum closed 5 years ago

eyeplum commented 5 years ago

This pull request fixes build warnings related to module paths in use declarations for beta and nightly toolchains.

eyeplum commented 5 years ago

Hmmm, looks like the crate:: notation is not supported by stable and 1.26.0.

behnam commented 5 years ago

Oh, I thought master is broken. Apparently it's not, but the builds here were failing because of the new code was based on the code before we allow warnings again.

So, let's just crate:: prefixes and all should be fine now. Right?

behnam commented 5 years ago

Uh, prev comment was for https://github.com/open-i18n/rust-unic/pull/227 .

Right, we can't actually do this here yet. Let's wait until we bump up min-rustc-version to what's beta right now.

Thanks for working on it, though, and sorry for my misleading comment. :(

eyeplum commented 5 years ago

No worries, it was fairly straight forward to work on and I've learnt something about Rust 2018.