open-ideas / IDEAS

Modelica library allowing simultaneous transient simulation of thermal and electrical systems at both building and feeder level.
131 stars 52 forks source link

OM test suite #1254

Open Mathadon opened 2 years ago

Mathadon commented 2 years ago

@casella suggests to include IDEAS in the OpenModelica test suite https://github.com/open-ideas/IDEAS/issues/1253#issuecomment-1085845104 . I think this is a good idea and I hope to be able to make some time for this? Can you comment on what exactly we'd have to do for this?

Mathadon commented 2 years ago

@sjoelund it is, but you would have to apply it on each and every component.

That indeed would be a bit of a hassle. :)

casella commented 2 years ago

@Mathadon I agree, though I still see a couple minor issues at the library level:

I guess you can fix them in the library, and then issue a patch release 3.0.1 that works better with OpenModelica than 3.0.0, and will work even better as we fix remaining issues in the tool.

Most other failures in the testsuite are either due to insufficient memory allocated to the test process, see #9038, or to the issue with protected element access, #9059. We'll address them ASAP on our side.

Then there are a few models that fail at initialization, these should be investigated further, maybe later this fall as we currently have to solve similar problems with other libraries (e.g. Buildings) with higher priority. It is possible that those other fixes will have a positive effect on IDEAS as well, we'll see that in regression reports.

Mathadon commented 2 years ago

LIDEAS protected variable access should be fixed through https://github.com/open-ideas/IDEAS/commit/cbd1414602b65f5f02ab8203417726be51ea478c

casella commented 2 years ago

Good, we should see the results tomorrow here.

Mathadon commented 2 years ago

Some more fixes pushed here https://github.com/open-ideas/IDEAS/commit/974f7f6e385ffc4141928aac0be463d07713b5e4

Mathadon commented 2 years ago

More fixes pushed: 73ea45f80bfa26b8d7ef1671f7082fc430a12b7c