search

open-ideas / IDEAS

Modelica library allowing simultaneous transient simulation of thermal and electrical systems at both building and feeder level.
131 stars 56 forks source link

Update constructions #1267

Open jelgerjansen opened 2 years ago

jelgerjansen commented 2 years ago

Some constructions within IDEAS.Buildings.Data.Constructions should be updated and some seem to be obsolete.

jelgerjansen commented 2 years ago

@Mathadon there are two different floors which can be used in combination with a floor heating system (FloorOnGround and InsulatedFloorHeating), but the latter seems to be a floor not suitable for a floor heating system (barely insulated and furthermore locGain seems to be wrong). I propose we update the documentation for FloorOnGround indicating this is not suitable in combination with a floor heating system?

jelgerjansen commented 2 years ago

After an internal discussion it is decided to remove FloorOnGround and replace it by InsulatedFloorHeating. Furthermore, a construction should be added to represent a floor between two zones on top of each other.

jelgerjansen commented 1 year ago

Let's wait implementing this till the CI is up and running (#1316) to not break any code.