search

open-ideas / IDEAS

Modelica library allowing simultaneous transient simulation of thermal and electrical systems at both building and feeder level.
131 stars 56 forks source link

Stack effect airflow #1310

Closed Mathadon closed 1 year ago

Mathadon commented 1 year ago

@kldjonge merry Christmas 😅

I found the bug.. I ended up writing debug outputs in TACO to debug the problem but I found it, see 83f1f21 for the fix. Can you verify that the PPD12 model now simulates with Dymola? (I don't have a license anymore)

Thank you!

@jelgerjansen can you merge this pull request into the IDEAS development branch? We can worry about the review work later as far as I am concerned.

jelgerjansen commented 1 year ago

@Mathadon I'll merge the pull request once @kldjonge confirms that the PPD12 model now simulates.

kldjonge commented 1 year ago

@jelgerjansen, I tested it by using the same fix on my local branch and it should indeed work. Anyhow this is a pull request from one development branch to another, so I will still need to further test/fix/verify so do not merge with master just yet.