search

open-ideas / IDEAS

Modelica library allowing simultaneous transient simulation of thermal and electrical systems at both building and feeder level.
131 stars 56 forks source link

Shading error access of conditional components #1367

Closed bmare-renson closed 1 month ago

bmare-renson commented 2 months ago 
          Hi,

Due to the changes to the PartialShading and Screen model I now get an error using OCT when simulating with screens:

The component Ctrl is conditional: Access of conditional components is only valid in connect statements.

I believe that instead of using Ctrl in the Screen model it should be replaced by Ctrl_internal

Originally posted by @bmare-renson in https://github.com/open-ideas/IDEAS/issues/1290#issuecomment-2250299599

lucasverleyen commented 2 months ago

@bmare-renson thank you for notifying us. I'll take a look at it in the short term!

jelgerjansen commented 2 months ago

@bmare-renson I pushed a fix to this branch. Could you confirm whether this removes the errors? If yes, I'll merge the changes to the master branch.

jelgerjansen commented 1 month ago

@bmare-renson since I didn't get any response, I presume PR #1369 solved the problem. I merged the PR and will close this issue. I any other problems occur regarding conditional components, feel free to re-open this issue.