open-ideas / IDEAS

Modelica library allowing simultaneous transient simulation of thermal and electrical systems at both building and feeder level.
133 stars 58 forks source link

Annex 60 conversion #3

Closed rubenbaetens closed 10 years ago

rubenbaetens commented 10 years ago

Convert the fluid-part of the IDEAS library based on the IEA Annex60 Baseclasses.

Mathadon commented 10 years ago

Shall we make a new branch for this? I think it will be more practical than working on a local branch.

damienpicard commented 10 years ago

I think a new branch would be indeed more convenient

Mathadon commented 10 years ago

Created new branch: https://github.com/open-ideas/IDEAS/tree/FluidPort

Mathadon commented 10 years ago

I suggest we remove IDEAS.Thermal.Components.Interfaces.Partials.Ambient and replace it by Annex 60 boundary_pT component?

Mathadon commented 10 years ago

The same for sensors?

damienpicard commented 10 years ago

To do so, we need to use the baseClasses of Annex 60. Once we have decided that we will convert it, then the purpose is to use a python script which automatically copy the full Annex 60 into IDEAS. So all the similar classes will become obsolete.

Mathadon commented 10 years ago

After discussing with Damien we suggest (to be discussed) the following changes in IDEAS.Thermal:

rubenbaetens commented 10 years ago
Mathadon commented 10 years ago

Should we update the IDEAS package description to warn users for the upcoming implementation of the (non-compatible) Annex60 baseclasses?

rubenbaetens commented 10 years ago

Maybe we should first figure out what will be not compatible with previous versions, if it is just connector(-names) i don't think it (i.e. non-backward-compatibility) is a big issue for now (i;e. for version 0.X instead of version X.0).

Mathadon commented 10 years ago

Renamed FluidPort branch to Annex60

Mathadon commented 10 years ago

Currently IDEAS uses MSL version 3.2. I think Damien already uses 3.2.1 in his development version. Either way we should make the update to 3.2.1 as well (assuming this is the last version of MSL?).

Mathadon commented 10 years ago

Actually 3.2.2 exists: https://www.modelica.org/documents I suppose we will just follow Annex60 then (3.2.1)?

damienpicard commented 10 years ago

The version automatically changes when you use dymola (version is updated to your current (open) MSL. As the versions are backward compatible, I would always use the latest version for the master branch.

Mathadon commented 10 years ago

Can these models be deleted? IDEAS.Fluid.Production.SolarCollector_Glazed IDEAS.Fluid.Production.SolarThermalSystem_Simple

Mathadon commented 10 years ago

solarcollector models removed

Mathadon commented 10 years ago

I guess the conversion itself is completed. Documentation etc, still to go..