open-ideas / StROBe

Python module for stochastic residential occupancy behavior for both building and district energy simulations.
38 stars 15 forks source link

Bug in cycle_load()? #16

Closed ulrichfilippi closed 5 years ago

ulrichfilippi commented 6 years ago

In cycle_load(), for a FridgeFreezer, calculated power is currently standby (zero for FridgeFreezer) except for single minutes where it is cycle_power (190 for FridgeFreezer). In other words, P is [0, ..., 0, 190, 0, ..., 0, 190, 0, ...]. Therefore, cycle_power is kept only for one minute, independent of cycle_length. Is this a bug or did I misinterpret?

Mathadon commented 6 years ago

@rubenbaetens @cprotopa do you have some wisdom to share about this?

cprotopa commented 5 years ago

Indeed, there is a problem with the implementation, the power is only kept for the 1st minute of the cycle. I'll need to take a closer look to propose a fix to this model. Thanks for pointing it out!