search

open-innovations / jrf-insight

JRF North England Insight Finder
https://open-innovations.github.io/jrf-insight/
MIT License
1 stars 0 forks source link

Geography tree includes duplicated levels #48

Closed gilesdring closed 5 months ago

gilesdring commented 1 year ago

The tree for Yorks and The Humber includes West and South Yorkshire Metropolitan Counties (code E11) as children, which looks duplicated when they only contain WYCA and SYMCA. Propose that we collapse these to a single layer.

Image

This might be as simple as finding E11 entries and replacing with the relevant E47 version, but worth discussing. The geojson files seem to work OK. West Yorks county doesn't appear in that one.

gilesdring commented 1 year ago

@ChristianSpence Let me know when you're in and we can discuss

gilesdring commented 1 year ago

Same is true of E11000001 -> E4700001 (Greater Manchester) and E11000002 -> E47000004 (Merseyside / Liverpool City Region). But, annoyingly, not E11000007 (Tyne and Wear) which contains E47000010 (North East) and E47000011 (North of Tyne)

gilesdring commented 1 year ago

I have manually patched this for now in https://github.com/open-innovations/jrf-insight/commit/cb80312ce52fab074814eff9d0b6fdcf0fb7c929

luke-strange commented 1 year ago

adding to sprint 12 for @ChristianSpence return