open-innovations / yff-data

Source of the Youth Futures Foundation data dashboard
https://data.youthfuturesfoundation.org/
MIT License
0 stars 2 forks source link

Improve tooltip text visibility for narrow/small screens #191

Closed ODILMichelle closed 1 year ago

ODILMichelle commented 1 year ago

Images from phone:

Landing page

Image

Main data page Image

slowe commented 1 year ago

Screenshot 2023-06-07 at 12-49-08 Labour Market - Youth Futures Foundation

This is an attempt at avoiding screen edges although sometimes it doesn't quite position correctly for unknown reasons. Is this good enough?

slowe commented 1 year ago

A slightly off-topic observation: the text colour in the orange tooltip has changed from white to black because I've updated the algorithm that calculates the most contrast-y text colour to the same one we are now using in OI Lume Charts. It does a better job.

ODILMichelle commented 1 year ago

@slowe - tested it, and it seems to do the trick on the two phones I have access to. Which means I'm happy it's done.

If you're happy it is done/you've done the testing you want, please feel free to close it!

slowe commented 1 year ago

I think I've got the best adjustment of tooltips I can do now.