search

open-iscsi / configshell-fb

configshell with additional modifications, see README
Apache License 2.0
28 stars 37 forks source link

Fix exception raised when 'help' is invoked #11

Closed cvubrugier closed 10 years ago

cvubrugier commented 10 years ago

Signed-off-by: Christophe Vu-Brugier cvubrugier@yahoo.fr

cvubrugier commented 10 years ago

Hi Andy,

This patch fixes the following traceback that occur when the help command is invoked without a topic:

Traceback (most recent call last):
  File "bin/targetcli", line 5, in <module>
    pkg_resources.run_script('targetcli-fb==2.1.fb35', 'targetcli')
  File "/home/tof/pyvenv/lib/python3.3/site-packages/setuptools-1.4.1-py3.3.egg/pkg_resources.py", line 492, in run_script
  File "/home/tof/pyvenv/lib/python3.3/site-packages/setuptools-1.4.1-py3.3.egg/pkg_resources.py", line 1357, in run_script
  File "/home/tof/pyvenv/lib/python3.3/site-packages/targetcli_fb-2.1.fb35-py3.3.egg/EGG-INFO/scripts/targetcli", line 100, in <module>
  File "/home/tof/pyvenv/lib/python3.3/site-packages/configshell_fb-1.1.12-py3.3.egg/configshell/shell.py", line 948, in run_interactive
    self._cli_loop()
  File "/home/tof/pyvenv/lib/python3.3/site-packages/configshell_fb-1.1.12-py3.3.egg/configshell/shell.py", line 777, in _cli_loop
    self.run_cmdline(cmdline)
  File "/home/tof/pyvenv/lib/python3.3/site-packages/configshell_fb-1.1.12-py3.3.egg/configshell/shell.py", line 891, in run_cmdline
    self._execute_command(path, command, pparams, kparams)
  File "/home/tof/pyvenv/lib/python3.3/site-packages/configshell_fb-1.1.12-py3.3.egg/configshell/shell.py", line 866, in _execute_command
    result = target.execute_command(command, pparams, kparams)
  File "/home/tof/pyvenv/lib/python3.3/site-packages/configshell_fb-1.1.12-py3.3.egg/configshell/node.py", line 1412, in execute_command
    return method(*pparams, **kparams)
  File "/home/tof/pyvenv/lib/python3.3/site-packages/configshell_fb-1.1.12-py3.3.egg/configshell/node.py", line 1140, in ui_command_help
    syntax, comments, defaults = self.get_command_syntax(topic)
  File "/home/tof/pyvenv/lib/python3.3/site-packages/configshell_fb-1.1.12-py3.3.egg/configshell/node.py", line 1583, in get_command_syntax
    method = self.get_command_method(command)
  File "/home/tof/pyvenv/lib/python3.3/site-packages/configshell_fb-1.1.12-py3.3.egg/configshell/node.py", line 1543, in get_command_method
    raise ValueError('No command named "%s".' % command)
ValueError: No command named "None".