Fix failing to pasre par=val parameters

open-iscsi / configshell-fb

configshell with additional modifications, see README

Apache License 2.0

28 stars 37 forks source link

Fix failing to pasre par=val parameters #36

Closed lxbsz closed 7 years ago

lxbsz commented 7 years ago

Through targetcli-fb to create LIO ceph target device like: /backstores/user:rbd> create block0 10G pool/rbd1/osd_op_timeout=30 the =30 will be ignored.

Signed-off-by: Xiubo Li lixiubo@cmss.chinamobile.com

mikechristie commented 7 years ago

Andy, one more question for this patch as it is also related to tcmu-runner:

https://github.com/open-iscsi/tcmu-runner/pull/288

We want to pass more parameters to tcmu-runner handlers. For ceph, we want to separate them with a ":" instead of "/" as it will allow ceph to use the same format for qemu and other tools.

Why is ":" not allowed? Is it because it is used in the LIO info file to separate settings and values?

mikechristie commented 7 years ago

Looks ok to me. Tested and Reviewed-by: Mike Christie mchristi@redhat.com