search

open-iscsi / open-isns

iSNS server and client for Linux
GNU Lesser General Public License v2.1
26 stars 22 forks source link

Disable deprecated initializations for openssl-1.1.0 #10

Closed eroen closed 7 years ago

eroen commented 7 years ago

This fixes several undefined reference errors when linking with openssl-1.1.0c.

X-Gentoo-Bug: 604454 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=604454

chris-se commented 7 years ago

I created the original patch that made open-isns work with OpenSSL 1.1 for Debian, and since current open-isns does still compile against 1.1.0c on Debian systems, I wanted to add a bit of background here: in your case it doesn't build, because your OpenSSL is compiled with either no-deprecated or --api=1.1.0 passed to OpenSSL's configure script, so the compatibility layer is not present anymore. If you configure OpenSSL 1.1 with compatibility enabled (as it is in Debian), build of open-isns will not fail. When creating the original patch, I had assumed that nobody would compile OpenSSL 1.1 without the compatibility layer for quite a while, so I didn't bother to include something like this in the first place, but apparently I was wrong.

However, I don't think one needs to rely on a compatibility layer here with the newest OpenSSL version, especially since open-isns doesn't require any non-standard initialization, so dropping the initialization in newer OpenSSL versions is a good idea (starting with 1.1, OpenSSL doesn't require explicit initialization anymore at all), so I'm in favor of applying this patch.

Acked-By: Christian Seiler \christian@iwakd.de\

prometheanfire commented 7 years ago

bug found in the package that JUST came out 👿

gonzoleeman commented 7 years ago

Looks good to me, and also compiles on older openssl on SUSE.