search

open-iscsi / rtslib-fb

Python library for configuring the Linux kernel-based multiprotocol SCSI target (LIO)
Apache License 2.0
72 stars 90 forks source link

targetcli may fail to start since eecb633 "Display a more meaningful error when targetcli cannot change dbroot" #105

Closed cvubrugier closed 5 years ago

cvubrugier commented 7 years ago

At revision eecb633, I added some code to display a more meaningful error when rtslib cannot change the "dbroot" value. This error can be raised when the new "dbroot" value points to a directory that does not exist.

However, there is at least another situation where the "dbroot" value cannot be changed: when the target drivers are already loaded:

# dmesg
db_root: cannot be changed: target drivers registered

This second situation should not prevent targetcli from starting.

stmcginnis commented 6 years ago

Is there a plan for a new release for this?

Current 2.1.64 release does not include this fix and is causing failure on Fedora for the Cinder project. I currently have a patch up to blacklist back to an earlier version, but would rather be able to bump up our required version to include this change.

agrover commented 6 years ago

Yes, let's do some new releases very soon.

cvubrugier commented 5 years ago

Fixed by commit Raise an error about failing to change the dbroot value only if the directory does not exist.